feat(insights): allow to pass init params #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymeric-giraudet
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84de95f:
|
Haroenv
approved these changes
Jan 11, 2024
packages/autocomplete-plugin-algolia-insights/src/createAlgoliaInsightsPlugin.ts
Show resolved
Hide resolved
dhayab
reviewed
Jan 11, 2024
Comment on lines
+148
to
+150
| if (insightsInitParams) { | ||
| insightsClient('init', { partial: true, ...insightsInitParams }); | ||
| } |
There was a problem hiding this comment.
Should we add a condition that checks we can use the partial init here (isModernInsightsClient()) ?
There was a problem hiding this comment.
as it's additional, and only when people pass the insights init parameters, I'm not sure if it's needed
dhayab
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FX-2699
Result
No need for changes in
autocomplete-coreas it takes types from the pluginTested it on playground with
useCookieanduserTokenand it works well